From 00f050fa5cc388e32a3e0c2832545f1e04f25d14 Mon Sep 17 00:00:00 2001 From: Russ Allbery Date: Wed, 18 Sep 2013 21:27:43 -0700 Subject: [PATCH] Use the portability layer and close a memory leak Free the unparsed principal name when checking passwords in Heimdal, and use the portability layer in the external strength program. --- external/heimdal-strength.c | 2 +- plugin/heimdal.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/external/heimdal-strength.c b/external/heimdal-strength.c index 613a9b4..d0f4e26 100644 --- a/external/heimdal-strength.c +++ b/external/heimdal-strength.c @@ -115,7 +115,7 @@ initialize(void) exit(1); } if (realm != NULL) { - free(realm); + krb5_free_default_realm(ctx, realm); free_realm(&realm_data); } if (pwcheck_init(&context, dictionary) != 0) { diff --git a/plugin/heimdal.c b/plugin/heimdal.c index f02aa50..6fe332d 100644 --- a/plugin/heimdal.c +++ b/plugin/heimdal.c @@ -103,6 +103,7 @@ heimdal_pwcheck(krb5_context context, krb5_principal principal, return 1; } result = pwcheck_check(data, pastring, name, message, length); + krb5_free_unparsed_name(ctx, name); free(pastring); pwcheck_close(data); return result; -- 2.39.2