Remove initializations older cppcheck doesn't like

Current cppcheck is better about ignoring initializations that
don't matter, but the older version running on GitHub Actions
complaints.  Fix a couple of those initializations to fix tests.

diff --git a/plugin/heimdal.c b/plugin/heimdal.c
index 13a18e8d73a4323873d64c7bb77afc8d8c766d52..b6bd54710fdc40bd0969e207cab17bf0ca2ab3b0 100644 (file)
--- a/plugin/heimdal.c
+++ b/plugin/heimdal.c
@@ -65,7 +65,7 @@ heimdal_pwcheck(krb5_context ctx, krb5_principal principal,
                 size_t length)
 {
     krb5_pwqual_moddata data = NULL;
-    char *pastring = NULL;
+    char *pastring;
     char *name = NULL;
     krb5_error_code code;
 

diff --git a/tests/plugin/mit-t.c b/tests/plugin/mit-t.c
index 7abc5d88df02588e1d2b6599ece52aad2dafd39b..b8920ef7a3edc773ba7a6e76e4f249fddff42123 100644 (file)
--- a/tests/plugin/mit-t.c
+++ b/tests/plugin/mit-t.c
@@ -238,7 +238,6 @@ main(void)
         bail("cannot find data/make-krb5-conf in the test suite");
     setup_argv[1] = path;
     setup_argv[2] = tmpdir;
-    setup_argv[3] = NULL;
 
     /* Point KRB5_CONFIG at the newly-generated krb5.conf file. */
     basprintf(&krb5_config, "KRB5_CONFIG=%s/krb5.conf", tmpdir);