]> eyrie.org Git - kerberos/krb5-strength.git/commitdiff
Do not install libtest-spelling-perl for CI
authorRuss Allbery <eagle@eyrie.org>
Sat, 16 May 2020 21:59:09 +0000 (14:59 -0700)
committerRuss Allbery <eagle@eyrie.org>
Sat, 16 May 2020 21:59:09 +0000 (14:59 -0700)
Installing the libtest-spelling-perl package also installs
libperl-critic-perl, and although we later install a newer version,
Perl::Critic dynamically picks up all of its policy modules.  This
means that installing the Ubuntu package will install obsolete
policy modules that will then be run during the test suite, causing
spurious failures.

ci/install

index ddac22a825c928d535215be2c9fc3267e7918192..163b4aa1e621f98a674f1ca9226fa8d01ba6f8a3 100755 (executable)
@@ -22,13 +22,12 @@ set -eux
 
 # Install packages.
 apt-get update -qq
-apt-get install aspell cpanminus cppcheck heimdal-multidev libcdb-dev    \
-        libdb-file-lock-perl libcrypt-pbkdf2-perl libdbd-sqlite3-perl    \
-        libdbi-perl libgetopt-long-descriptive-perl libipc-run-perl      \
-        libjson-perl libkrb5-dev libperl6-slurp-perl libreadonly-perl    \
-        libsqlite3-dev libtest-minimumversion-perl libtest-pod-perl      \
-        libtest-spelling-perl libtest-strict-perl pkg-config perl sqlite \
-        tinycdb valgrind
+apt-get install aspell cpanminus cppcheck heimdal-multidev libcdb-dev   \
+        libdb-file-lock-perl libcrypt-pbkdf2-perl libdbd-sqlite3-perl   \
+        libdbi-perl libgetopt-long-descriptive-perl libipc-run-perl     \
+        libjson-perl libkrb5-dev libperl6-slurp-perl libreadonly-perl   \
+        libsqlite3-dev libtest-pod-perl libtest-spelling-perl           \
+        libtest-strict-perl pkg-config perl sqlite tinycdb valgrind
 
 # Dependencies for Perl tests.
 cpanm Perl::Tidy