Also fix -a and -b checks for krenew, add NEWS entry

diff --git a/NEWS b/NEWS
index 02f46ecb992fdc3a126a705467f78c306641bb3f..cdf876a8110d42652aba9a30d77389b54fb94c2b 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -32,6 +32,9 @@ kstart 4.2 (unreleased)
     compatibility.  Consider always using -a with -K.  Based on a patch by
     Andrew Deason.
 
+    Fix k5start and krenew to not incorrectly reject the -b flag in
+    conjunction with -K or a command.  Patch from Dr. Lars Hanke.
+
 kstart 4.1 (2012-01-07)
 
     Fix a regression introduced in kstart 4.0 that caused k5start -H and

diff --git a/krenew.c b/krenew.c
index 9ae4c5b3e496b3c01e75cce94926e97435094f1b..4a553415e07b542890faaaf58ba2a62bd242ee8c 100644 (file)
--- a/krenew.c
+++ b/krenew.c
@@ -314,9 +314,9 @@ main(int argc, char *argv[])
 
     /* Check the arguments for consistency. */
     run_as_daemon = (config.keep_ticket != 0 || config.command != NULL);
-    if (config.always_renew && run_as_daemon)
+    if (config.always_renew && !run_as_daemon)
         die("-a only makes sense with -K or a command to run");
-    if (config.background && run_as_daemon)
+    if (config.background && !run_as_daemon)
         die("-b only makes sense with -K or a command to run");
     if (config.happy_ticket > 0 && config.command != NULL)
         die("-H option cannot be used with a command");