Update to rra-c-util 5.4

[kerberos/krb5-strength.git] / tests / perl / critic-t

diff --git a/tests/perl/critic-t b/tests/perl/critic-t
index 89b872d100232bd39bfb7834247c4e620ffbefa7..c66227c39e7c5a25bf7ac691aa3035c9570c3ba7 100755 (executable)
--- a/tests/perl/critic-t
+++ b/tests/perl/critic-t
@@ -2,15 +2,11 @@
 #
 # Check for perlcritic errors in included Perl scripts.
 #
-# Checks all Perl scripts in the tree for problems uncovered by perlcritic.
-# This test is disabled unless RRA_MAINTAINER_TESTS is set, since coding style
-# will not interfere with functionality.
-#
 # The canonical version of this file is maintained in the rra-c-util package,
 # which can be found at <http://www.eyrie.org/~eagle/software/rra-c-util/>.
 #
-# Written by Russ Allbery <rra@stanford.edu>
-# Copyright 2012, 2013
+# Written by Russ Allbery <eagle@eyrie.org>
+# Copyright 2012, 2013, 2014
 #     The Board of Trustees of the Leland Stanford Junior University
 #
 # Permission is hereby granted, free of charge, to any person obtaining a
@@ -37,13 +33,15 @@ use warnings;
 
 use lib "$ENV{SOURCE}/tap/perl";
 
+use File::Spec;
 use Test::More;
-use Test::RRA qw(skip_unless_maintainer use_prereq);
+use Test::RRA qw(skip_unless_author use_prereq);
 use Test::RRA::Automake qw(automake_setup perl_dirs test_file_path);
 use Test::RRA::Config qw(@CRITIC_IGNORE);
 
-# Skip tests unless we're running the test suite in maintainer mode.
-skip_unless_maintainer('Coding style tests');
+# Skip tests unless we're running author tests since this test is too
+# sensitive to the exact version of Perl::Critic to be generally useful.
+skip_unless_author('Coding style tests');
 
 # Set up Automake testing.
 automake_setup();
@@ -51,11 +49,22 @@ automake_setup();
 # Load prerequisite modules.
 use_prereq('Test::Perl::Critic');
 
+# Due to an annoying bug in Perl::Tidy 20130922, we cannot run tests if the
+# source directory is read-only.  It unconditionally tries to create a log
+# file in the current directory and fails to run any checks if it cannot.
+if (!-w File::Spec->curdir()) {
+    plan skip_all => 'Perl::Tidy needs writable source directory';
+}
+
 # Force the embedded Perl::Tidy check to use the correct configuration.
-local $ENV{PERLTIDY} = test_file_path('/data/perltidyrc');
+local $ENV{PERLTIDY} = test_file_path('data/perltidyrc');
 
 # Import the configuration file.
 Test::Perl::Critic->import(-profile => test_file_path('data/perlcriticrc'));
 
 # Finally, run the actual tests.
 all_critic_ok(perl_dirs({ skip => [@CRITIC_IGNORE] }));
+
+# On Debian with perltidy 20130922-1, a perltidy.LOG file gets left behind
+# in the current directory.  Remove it if it exists.
+unlink('perltidy.LOG');